Decimal to roman pythonRoman Numeral to Decimal ConversionConverting Roman numerals to decimalRoman numeral converter in RubyRoman numerals to decimalRoman numeral to decimal converterCurrency converter in Python 2.7“Merchants Guide to Galaxy” challengeGreed Dice Scoring Game expanded - Python KoansArea and volume calculatorNumber of possible numbers in roman number string
Is there a hemisphere-neutral way of specifying a season?
How do I write bicross product symbols in latex?
Is the Joker left-handed?
When a company launches a new product do they "come out" with a new product or do they "come up" with a new product?
What's the difference between 'rename' and 'mv'?
What is the PIE reconstruction for word-initial alpha with rough breathing?
I'm flying to France today and my passport expires in less than 2 months
Can a virus destroy the BIOS of a modern computer?
Today is the Center
Why do I get two different answers for this counting problem?
What to put in ESTA if staying in US for a few days before going on to Canada
How can I prevent hyper evolved versions of regular creatures from wiping out their cousins?
Watching something be written to a file live with tail
Twin primes whose sum is a cube
What is the word for reserving something for yourself before others do?
Can one be a co-translator of a book, if he does not know the language that the book is translated into?
Alternative to sending password over mail?
How can I tell someone that I want to be his or her friend?
Why does Kotter return in Welcome Back Kotter
Anagram holiday
Combinations of multiple lists
How to prevent "they're falling in love" trope
In Romance of the Three Kingdoms why do people still use bamboo sticks when papers are already invented?
Should I tell management that I intend to leave due to bad software development practices?
Decimal to roman python
Roman Numeral to Decimal ConversionConverting Roman numerals to decimalRoman numeral converter in RubyRoman numerals to decimalRoman numeral to decimal converterCurrency converter in Python 2.7“Merchants Guide to Galaxy” challengeGreed Dice Scoring Game expanded - Python KoansArea and volume calculatorNumber of possible numbers in roman number string
.everyoneloves__top-leaderboard:empty,.everyoneloves__mid-leaderboard:empty,.everyoneloves__bot-mid-leaderboard:empty margin-bottom:0;
$begingroup$
I'm a beginner as you can see and I would like to know how I can improve my code. Studying for 6 months now. Thank you.
roman_dict = 1: 'I', 4: 'IV', 5: 'V', 9: 'IX', 10: 'X', 40: 'XL', 50: 'L', 90: 'XC', 100: 'C', 400: 'CD',
500: 'D', 900: 'CM', 1000: 'M'
divide_list = [1000, 100, 10, 1]
def not_in_dict(fixed_decimal, divide_num):
sub_count = 0
sub_roman_multi = roman_dict[divide_num]
temp_decimal = fixed_decimal
while temp_decimal not in roman_dict:
temp_decimal -= divide_num
sub_count += 1
return roman_dict[temp_decimal]+(sub_count*sub_roman_multi)
def decimal_to_roman(decimal):
original_decimal = decimal
roman = ""
for divide_num in divide_list:
if decimal >= divide_num:
reminder = decimal//divide_num
if(reminder >= 1) and ((reminder*divide_num) in roman_dict):
roman += roman_dict[(reminder*divide_num)]
decimal -= reminder*divide_num
else:
roman += not_in_dict(reminder*divide_num, divide_num)
decimal -= (reminder*divide_num)
return str(original_decimal)+' = '+roman
python roman-numerals
New contributor
$endgroup$
add a comment |
$begingroup$
I'm a beginner as you can see and I would like to know how I can improve my code. Studying for 6 months now. Thank you.
roman_dict = 1: 'I', 4: 'IV', 5: 'V', 9: 'IX', 10: 'X', 40: 'XL', 50: 'L', 90: 'XC', 100: 'C', 400: 'CD',
500: 'D', 900: 'CM', 1000: 'M'
divide_list = [1000, 100, 10, 1]
def not_in_dict(fixed_decimal, divide_num):
sub_count = 0
sub_roman_multi = roman_dict[divide_num]
temp_decimal = fixed_decimal
while temp_decimal not in roman_dict:
temp_decimal -= divide_num
sub_count += 1
return roman_dict[temp_decimal]+(sub_count*sub_roman_multi)
def decimal_to_roman(decimal):
original_decimal = decimal
roman = ""
for divide_num in divide_list:
if decimal >= divide_num:
reminder = decimal//divide_num
if(reminder >= 1) and ((reminder*divide_num) in roman_dict):
roman += roman_dict[(reminder*divide_num)]
decimal -= reminder*divide_num
else:
roman += not_in_dict(reminder*divide_num, divide_num)
decimal -= (reminder*divide_num)
return str(original_decimal)+' = '+roman
python roman-numerals
New contributor
$endgroup$
add a comment |
$begingroup$
I'm a beginner as you can see and I would like to know how I can improve my code. Studying for 6 months now. Thank you.
roman_dict = 1: 'I', 4: 'IV', 5: 'V', 9: 'IX', 10: 'X', 40: 'XL', 50: 'L', 90: 'XC', 100: 'C', 400: 'CD',
500: 'D', 900: 'CM', 1000: 'M'
divide_list = [1000, 100, 10, 1]
def not_in_dict(fixed_decimal, divide_num):
sub_count = 0
sub_roman_multi = roman_dict[divide_num]
temp_decimal = fixed_decimal
while temp_decimal not in roman_dict:
temp_decimal -= divide_num
sub_count += 1
return roman_dict[temp_decimal]+(sub_count*sub_roman_multi)
def decimal_to_roman(decimal):
original_decimal = decimal
roman = ""
for divide_num in divide_list:
if decimal >= divide_num:
reminder = decimal//divide_num
if(reminder >= 1) and ((reminder*divide_num) in roman_dict):
roman += roman_dict[(reminder*divide_num)]
decimal -= reminder*divide_num
else:
roman += not_in_dict(reminder*divide_num, divide_num)
decimal -= (reminder*divide_num)
return str(original_decimal)+' = '+roman
python roman-numerals
New contributor
$endgroup$
I'm a beginner as you can see and I would like to know how I can improve my code. Studying for 6 months now. Thank you.
roman_dict = 1: 'I', 4: 'IV', 5: 'V', 9: 'IX', 10: 'X', 40: 'XL', 50: 'L', 90: 'XC', 100: 'C', 400: 'CD',
500: 'D', 900: 'CM', 1000: 'M'
divide_list = [1000, 100, 10, 1]
def not_in_dict(fixed_decimal, divide_num):
sub_count = 0
sub_roman_multi = roman_dict[divide_num]
temp_decimal = fixed_decimal
while temp_decimal not in roman_dict:
temp_decimal -= divide_num
sub_count += 1
return roman_dict[temp_decimal]+(sub_count*sub_roman_multi)
def decimal_to_roman(decimal):
original_decimal = decimal
roman = ""
for divide_num in divide_list:
if decimal >= divide_num:
reminder = decimal//divide_num
if(reminder >= 1) and ((reminder*divide_num) in roman_dict):
roman += roman_dict[(reminder*divide_num)]
decimal -= reminder*divide_num
else:
roman += not_in_dict(reminder*divide_num, divide_num)
decimal -= (reminder*divide_num)
return str(original_decimal)+' = '+roman
python roman-numerals
python roman-numerals
New contributor
New contributor
edited 14 hours ago
Graipher
26.7k54092
26.7k54092
New contributor
asked 15 hours ago
OfeksOfeks
283
283
New contributor
New contributor
add a comment |
add a comment |
1 Answer
1
active
oldest
votes
$begingroup$
If you use a list of tuples instead of a dictionary and reverse the order, you can simply iterate over it. Your while
loop also becomes a lot easier to understand and there is no longer any need to outsource it to another function that returns the literal and its count.
Instead of manually adding strings (something you should basically never do in in Python), use str.join
.
ROMAN_LITERALS = [(1000, 'M'), (900, 'CM'), (500, 'D'), (400, 'CD'), (100, 'C'),
(90, 'XC'), (50, 'L'), (40, 'XL'), (10, 'X'), (9, 'IX'),
(5, 'V'), (4, 'IV'), (1, 'I')]
def decimal_to_roman(x):
out = []
for value, literal in ROMAN_LITERALS:
while x >= value:
x -= value
out.append(literal)
return "".join(out)
Instead of the while
loop you can also use integer division like you did:
def decimal_to_roman(x):
out = []
for value, literal in ROMAN_LITERALS:
n = x // value # will be 0 if value is too large
out.extend([literal] * n) # will not do anything if n == 0
x -= n * value # will also not do anything if n == 0
return "".join(out)
$endgroup$
$begingroup$
wow. looks so easy now, thank you. that's great.
$endgroup$
– Ofeks
12 hours ago
$begingroup$
@Ofeks: If this helped you, consider accepting it as the correct answer (by clicking the checkmark to the left of the answer). It is customary to wait about 24 hours, though, to give everyon on the globe a chance to answer and not discourage other people from commenting.
$endgroup$
– Graipher
12 hours ago
add a comment |
Your Answer
StackExchange.ifUsing("editor", function ()
return StackExchange.using("mathjaxEditing", function ()
StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix)
StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
);
);
, "mathjax-editing");
StackExchange.ifUsing("editor", function ()
StackExchange.using("externalEditor", function ()
StackExchange.using("snippets", function ()
StackExchange.snippets.init();
);
);
, "code-snippets");
StackExchange.ready(function()
var channelOptions =
tags: "".split(" "),
id: "196"
;
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function()
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled)
StackExchange.using("snippets", function()
createEditor();
);
else
createEditor();
);
function createEditor()
StackExchange.prepareEditor(
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: false,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: null,
bindNavPrevention: true,
postfix: "",
imageUploader:
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
,
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
);
);
Ofeks is a new contributor. Be nice, and check out our Code of Conduct.
Sign up or log in
StackExchange.ready(function ()
StackExchange.helpers.onClickDraftSave('#login-link');
);
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function ()
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f216852%2fdecimal-to-roman-python%23new-answer', 'question_page');
);
Post as a guest
Required, but never shown
1 Answer
1
active
oldest
votes
1 Answer
1
active
oldest
votes
active
oldest
votes
active
oldest
votes
$begingroup$
If you use a list of tuples instead of a dictionary and reverse the order, you can simply iterate over it. Your while
loop also becomes a lot easier to understand and there is no longer any need to outsource it to another function that returns the literal and its count.
Instead of manually adding strings (something you should basically never do in in Python), use str.join
.
ROMAN_LITERALS = [(1000, 'M'), (900, 'CM'), (500, 'D'), (400, 'CD'), (100, 'C'),
(90, 'XC'), (50, 'L'), (40, 'XL'), (10, 'X'), (9, 'IX'),
(5, 'V'), (4, 'IV'), (1, 'I')]
def decimal_to_roman(x):
out = []
for value, literal in ROMAN_LITERALS:
while x >= value:
x -= value
out.append(literal)
return "".join(out)
Instead of the while
loop you can also use integer division like you did:
def decimal_to_roman(x):
out = []
for value, literal in ROMAN_LITERALS:
n = x // value # will be 0 if value is too large
out.extend([literal] * n) # will not do anything if n == 0
x -= n * value # will also not do anything if n == 0
return "".join(out)
$endgroup$
$begingroup$
wow. looks so easy now, thank you. that's great.
$endgroup$
– Ofeks
12 hours ago
$begingroup$
@Ofeks: If this helped you, consider accepting it as the correct answer (by clicking the checkmark to the left of the answer). It is customary to wait about 24 hours, though, to give everyon on the globe a chance to answer and not discourage other people from commenting.
$endgroup$
– Graipher
12 hours ago
add a comment |
$begingroup$
If you use a list of tuples instead of a dictionary and reverse the order, you can simply iterate over it. Your while
loop also becomes a lot easier to understand and there is no longer any need to outsource it to another function that returns the literal and its count.
Instead of manually adding strings (something you should basically never do in in Python), use str.join
.
ROMAN_LITERALS = [(1000, 'M'), (900, 'CM'), (500, 'D'), (400, 'CD'), (100, 'C'),
(90, 'XC'), (50, 'L'), (40, 'XL'), (10, 'X'), (9, 'IX'),
(5, 'V'), (4, 'IV'), (1, 'I')]
def decimal_to_roman(x):
out = []
for value, literal in ROMAN_LITERALS:
while x >= value:
x -= value
out.append(literal)
return "".join(out)
Instead of the while
loop you can also use integer division like you did:
def decimal_to_roman(x):
out = []
for value, literal in ROMAN_LITERALS:
n = x // value # will be 0 if value is too large
out.extend([literal] * n) # will not do anything if n == 0
x -= n * value # will also not do anything if n == 0
return "".join(out)
$endgroup$
$begingroup$
wow. looks so easy now, thank you. that's great.
$endgroup$
– Ofeks
12 hours ago
$begingroup$
@Ofeks: If this helped you, consider accepting it as the correct answer (by clicking the checkmark to the left of the answer). It is customary to wait about 24 hours, though, to give everyon on the globe a chance to answer and not discourage other people from commenting.
$endgroup$
– Graipher
12 hours ago
add a comment |
$begingroup$
If you use a list of tuples instead of a dictionary and reverse the order, you can simply iterate over it. Your while
loop also becomes a lot easier to understand and there is no longer any need to outsource it to another function that returns the literal and its count.
Instead of manually adding strings (something you should basically never do in in Python), use str.join
.
ROMAN_LITERALS = [(1000, 'M'), (900, 'CM'), (500, 'D'), (400, 'CD'), (100, 'C'),
(90, 'XC'), (50, 'L'), (40, 'XL'), (10, 'X'), (9, 'IX'),
(5, 'V'), (4, 'IV'), (1, 'I')]
def decimal_to_roman(x):
out = []
for value, literal in ROMAN_LITERALS:
while x >= value:
x -= value
out.append(literal)
return "".join(out)
Instead of the while
loop you can also use integer division like you did:
def decimal_to_roman(x):
out = []
for value, literal in ROMAN_LITERALS:
n = x // value # will be 0 if value is too large
out.extend([literal] * n) # will not do anything if n == 0
x -= n * value # will also not do anything if n == 0
return "".join(out)
$endgroup$
If you use a list of tuples instead of a dictionary and reverse the order, you can simply iterate over it. Your while
loop also becomes a lot easier to understand and there is no longer any need to outsource it to another function that returns the literal and its count.
Instead of manually adding strings (something you should basically never do in in Python), use str.join
.
ROMAN_LITERALS = [(1000, 'M'), (900, 'CM'), (500, 'D'), (400, 'CD'), (100, 'C'),
(90, 'XC'), (50, 'L'), (40, 'XL'), (10, 'X'), (9, 'IX'),
(5, 'V'), (4, 'IV'), (1, 'I')]
def decimal_to_roman(x):
out = []
for value, literal in ROMAN_LITERALS:
while x >= value:
x -= value
out.append(literal)
return "".join(out)
Instead of the while
loop you can also use integer division like you did:
def decimal_to_roman(x):
out = []
for value, literal in ROMAN_LITERALS:
n = x // value # will be 0 if value is too large
out.extend([literal] * n) # will not do anything if n == 0
x -= n * value # will also not do anything if n == 0
return "".join(out)
edited 11 hours ago
answered 14 hours ago
GraipherGraipher
26.7k54092
26.7k54092
$begingroup$
wow. looks so easy now, thank you. that's great.
$endgroup$
– Ofeks
12 hours ago
$begingroup$
@Ofeks: If this helped you, consider accepting it as the correct answer (by clicking the checkmark to the left of the answer). It is customary to wait about 24 hours, though, to give everyon on the globe a chance to answer and not discourage other people from commenting.
$endgroup$
– Graipher
12 hours ago
add a comment |
$begingroup$
wow. looks so easy now, thank you. that's great.
$endgroup$
– Ofeks
12 hours ago
$begingroup$
@Ofeks: If this helped you, consider accepting it as the correct answer (by clicking the checkmark to the left of the answer). It is customary to wait about 24 hours, though, to give everyon on the globe a chance to answer and not discourage other people from commenting.
$endgroup$
– Graipher
12 hours ago
$begingroup$
wow. looks so easy now, thank you. that's great.
$endgroup$
– Ofeks
12 hours ago
$begingroup$
wow. looks so easy now, thank you. that's great.
$endgroup$
– Ofeks
12 hours ago
$begingroup$
@Ofeks: If this helped you, consider accepting it as the correct answer (by clicking the checkmark to the left of the answer). It is customary to wait about 24 hours, though, to give everyon on the globe a chance to answer and not discourage other people from commenting.
$endgroup$
– Graipher
12 hours ago
$begingroup$
@Ofeks: If this helped you, consider accepting it as the correct answer (by clicking the checkmark to the left of the answer). It is customary to wait about 24 hours, though, to give everyon on the globe a chance to answer and not discourage other people from commenting.
$endgroup$
– Graipher
12 hours ago
add a comment |
Ofeks is a new contributor. Be nice, and check out our Code of Conduct.
Ofeks is a new contributor. Be nice, and check out our Code of Conduct.
Ofeks is a new contributor. Be nice, and check out our Code of Conduct.
Ofeks is a new contributor. Be nice, and check out our Code of Conduct.
Thanks for contributing an answer to Code Review Stack Exchange!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
Use MathJax to format equations. MathJax reference.
To learn more, see our tips on writing great answers.
Sign up or log in
StackExchange.ready(function ()
StackExchange.helpers.onClickDraftSave('#login-link');
);
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function ()
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f216852%2fdecimal-to-roman-python%23new-answer', 'question_page');
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function ()
StackExchange.helpers.onClickDraftSave('#login-link');
);
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function ()
StackExchange.helpers.onClickDraftSave('#login-link');
);
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function ()
StackExchange.helpers.onClickDraftSave('#login-link');
);
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown